[webkit-reviews] review granted: [Bug 106400] Allow tiled WKViews to have transparent backgrounds : [Attachment 181807] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 106400: Allow tiled WKViews to have transparent backgrounds
https://bugs.webkit.org/show_bug.cgi?id=106400

Attachment 181807: Patch
https://bugs.webkit.org/attachment.cgi?id=181807&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=181807&action=review


> Source/WebCore/ChangeLog:8
> +	   When WKViews are set to have transparent backgrounds, they still

were set?

> Source/WebCore/ChangeLog:22
> +	   linen, so enderLayerCompositor::requiresOverhangAreasLayer() was
changed

RenderLayerCompositor.

> Source/WebCore/rendering/RenderLayerBacking.cpp:266
> -	       isTransparent = frameView->isTransparent();
> +	       isTransparent = !frameView->hasOpaqueBackground();

I think you should rename this variable to hasOpaqueBackground.