[webkit-reviews] review requested: [Bug 102828] r134080 causes heap problem on linux systems where PAGESIZE != 4096 : [Attachment 181941] proposed patch.

[bugzilla-daemon at webkit.org]

Balazs Kilvady <kilvadyb at homejinni.com> has asked  for review:
Bug 102828: r134080 causes heap problem on linux systems where PAGESIZE != 4096
https://bugs.webkit.org/show_bug.cgi?id=102828

Attachment 181941: proposed patch.
https://bugs.webkit.org/attachment.cgi?id=181941&action=review

------- Additional Comments from Balazs Kilvady <kilvadyb at homejinni.com>
We are not satisfied with this patch, but would like to start a discussion. One
possible solution is what we did in the patch: to introduce a new base class
which defines the block size for the HeapBlocks in question (forcing a common
value). Another possible solution would be to just introduce a new constant for
this purpose and use it as the default value for both the blockSize in the heap
blocks and the	gcMarkStackSegmentSize option.

An other option is to fix MarkStackArray to use block size of heap blocks. We
aren't sure if gcMarkStackSegmentSize is good to use in MarkStackArray
implementation as it depends on MarkStackSegment::blockSize.