[webkit-reviews] review denied: [Bug 106418] Refactoring class CSSMediaRule and class WebKitCSSRegionRule : [Attachment 181865] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 9 10:04:29 PST 2013


Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Takashi Sakamoto
<tasak at google.com>'s request for review:
Bug 106418: Refactoring class CSSMediaRule and class WebKitCSSRegionRule
https://bugs.webkit.org/show_bug.cgi?id=106418

Attachment 181865: Patch
https://bugs.webkit.org/attachment.cgi?id=181865&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
I agree with Alexey, this patch looks sad because of gratuitous templating. The
thing is, you almost don't need these templates and I am confident this
refactoring can be done without them.


More information about the webkit-reviews mailing list