[webkit-reviews] review granted: [Bug 105846] [WK2][EFL] Add guard around NativeWebTouchEvent : [Attachment 181876] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Seokju Kwon
<seokju.kwon at gmail.com>'s request for review:
Bug 105846: [WK2][EFL] Add guard around NativeWebTouchEvent
https://bugs.webkit.org/show_bug.cgi?id=105846

Attachment 181876: Patch
https://bugs.webkit.org/attachment.cgi?id=181876&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
(In reply to comment #11)
> (From update of attachment 181876 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=181876&action=review
> 
> > Source/WebKit2/Shared/efl/NativeWebTouchEventEfl.cpp:27
> > +#if ENABLE(TOUCH_EVENTS)
> 
> NativeWebTouchEventEfl.cpp already uses this guard. 

You can just move that guard up under the #include of config.h.

> I think this build break occurs because NativeWebTouchEvent.h doesn't use the
guard. I think it would be good to add this guard to NativeWebTouchEvent.h.

See my previous comments.