[webkit-reviews] review granted: [Bug 106294] [Shadow DOM] Distribution related code on ElementShadow should be minimized. : [Attachment 181882] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 9 09:24:44 PST 2013


Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Hajime Morrita
<morrita at google.com>'s request for review:
Bug 106294: [Shadow DOM] Distribution related code on ElementShadow should be
minimized.
https://bugs.webkit.org/show_bug.cgi?id=106294

Attachment 181882: Patch
https://bugs.webkit.org/attachment.cgi?id=181882&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181882&action=review


> Source/WebCore/dom/ElementShadow.h:69
> +    void invalidateDistribution() {
m_distributor.invalidateDistribution(host()); }
> +    void ensureDistribution() { m_distributor.ensureDistribution(host()); }
> +    void didAffectSelector(AffectedSelectorMask mask) {
m_distributor.didAffectSelector(host(), mask); }
> +    void willAffectSelector() { m_distributor.willAffectSelector(host()); }

I wonder if these plumb-throughs could be just eliminated?


More information about the webkit-reviews mailing list