[webkit-reviews] review granted: [Bug 88961] [GTK][EFL] http/tests/misc/redirect-to-about-blank.html is failing : [Attachment 181443] patch - handle redirection inside WebKit

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 9 05:46:42 PST 2013


Gustavo Noronha (kov) <gns at gnome.org> has granted Dan Winship
<danw at gnome.org>'s request for review:
Bug 88961: [GTK][EFL] http/tests/misc/redirect-to-about-blank.html is failing
https://bugs.webkit.org/show_bug.cgi?id=88961

Attachment 181443: patch - handle redirection inside WebKit
https://bugs.webkit.org/attachment.cgi?id=181443&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181443&action=review


LGTM other than Gyuyoung Kim's nit and mine. I think it makes sense to close
61122 as a dup as well as 105015, since it's obsolete now like you said.

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:401
> +    // Some 3xx status codes aren't actually redirects

Missing period.


More information about the webkit-reviews mailing list