[webkit-reviews] review granted: [Bug 105631] [GTK] Add support for loading web process extensions : [Attachment 181029] New patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 105631: [GTK] Add support for loading web process extensions
https://bugs.webkit.org/show_bug.cgi?id=105631

Attachment 181029: New patch
https://bugs.webkit.org/attachment.cgi?id=181029&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181029&action=review


Looks good to me, would be good to have a facility to let applications specify
a private modules path so that we don't end up with a lot of modules that won't
be used loaded unnecessarily, or with applications relying on others' modules.
Other than that the API looks great to me, too.

> Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.cpp:117
> + *
> + * Get the web page of the given @page_id.
> + *
> + * Returns: the #WebKitWebPage for the given @page_id, or %NULL if the
> + *	 identifier doesn't correspond to an exsiting web page.

Be useful to state the WebExtension owns the object that is returned and
annotate transfer none.