[webkit-reviews] review denied: [Bug 100225] [EFL][WK2] Add APIs to get/set the default text encoding name : [Attachment 180964] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Yuni Jeong
<yhnet.jung at samsung.com>'s request for review:
Bug 100225: [EFL][WK2] Add APIs to get/set the default text encoding name
https://bugs.webkit.org/show_bug.cgi?id=100225

Attachment 180964: Patch
https://bugs.webkit.org/attachment.cgi?id=180964&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=180964&action=review


>> Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp:62
>> +	m_defaultTextEncoding = defaultTextEncoding.utf8().data();

This is incorrect. The char buffer is invalid pas that line.
You need to hold on the CString if you want to keep a character buffer alive.