[webkit-reviews] review granted: [Bug 106398] DFG shouldn't treat the 'this' argument as being captured if a code block uses arguments : [Attachment 181800] the patch

[bugzilla-daemon at webkit.org]

Mark Hahnenberg <mhahnenberg at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 106398: DFG shouldn't treat the 'this' argument as being captured if a code
block uses arguments
https://bugs.webkit.org/show_bug.cgi?id=106398

Attachment 181800: the patch
https://bugs.webkit.org/attachment.cgi?id=181800&action=review

------- Additional Comments from Mark Hahnenberg <mhahnenberg at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=181800&action=review


r=me

> Source/JavaScriptCore/dfg/DFGValidate.cpp:80
> +	   // Validate that all local variable phis at the head of the root
block are dead.

No "phis".

> Source/JavaScriptCore/dfg/DFGValidate.cpp:297
> +    void reportValidationContext()

Remove.