[webkit-reviews] review granted: [Bug 106123] REGRESSION(r138222?): [Mac WK1] http/tests/appcache/main-resource-redirect.html asserts in WebFrameLoaderClient::dispatchDidFinishLoading : [Attachment 181802] Address ap's comments

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Nate Chapin
<japhet at chromium.org>'s request for review:
Bug 106123: REGRESSION(r138222?): [Mac WK1]
http/tests/appcache/main-resource-redirect.html asserts in
WebFrameLoaderClient::dispatchDidFinishLoading
https://bugs.webkit.org/show_bug.cgi?id=106123

Attachment 181802: Address ap's comments
https://bugs.webkit.org/attachment.cgi?id=181802&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181802&action=review


> Source/WebCore/loader/MainResourceLoader.cpp:193
> +	   if (resourceLoader)

I asked Nate on IRC, and he doesn't know if this can actually happen in
practice. It's very confusing to have unnecessary null checks just in case, but
given the urgency, I guess I can grudgingly say r=me.

> Source/WebCore/loader/ResourceLoader.h:143
> +    void setSendCallbackPolicy(SendCallbackPolicy sendLoadCallbacks)  {
m_options.sendLoadCallbacks = sendLoadCallbacks; }

Extra space before '{'.