[webkit-reviews] review granted: [Bug 103621] Caret is incorrectly painted for a contenteditable <div> containing a <br> in vertical writing mode : [Attachment 181689] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Arpita Bahuguna
<arpitabahuguna at gmail.com>'s request for review:
Bug 103621: Caret is incorrectly painted for a contenteditable <div> containing
a <br> in vertical writing mode
https://bugs.webkit.org/show_bug.cgi?id=103621

Attachment 181689: Patch
https://bugs.webkit.org/attachment.cgi?id=181689&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181689&action=review


> Source/WebCore/rendering/RenderText.cpp:1617
> +    IntRect rect;
> +
> +    rect = linesBoundingBox();

You can just do:
IntRect rect = linesBoundingBox();

>
LayoutTests/editing/selection/caret-in-div-containing-br-in-vertical-mode-expec
ted.txt:3
> +
> +some text
> +

Could you hide this test when ran inside a DRT?

>
LayoutTests/editing/selection/caret-in-div-containing-br-in-vertical-mode.html:
24
> +	   

Nit: whitespace.

>
LayoutTests/editing/selection/caret-in-div-containing-br-in-vertical-mode.html:
29
> +    }

Setting style.display to none would work.

>
LayoutTests/editing/selection/caret-in-div-containing-br-in-vertical-mode.html:
30
> +    

Nit: whitespace.