[webkit-reviews] review denied: [Bug 105846] Add guard around NativeWebTouchEvent : [Attachment 181790] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Seokju Kwon
<seokju.kwon at gmail.com>'s request for review:
Bug 105846: Add guard around NativeWebTouchEvent
https://bugs.webkit.org/show_bug.cgi?id=105846

Attachment 181790: Patch
https://bugs.webkit.org/attachment.cgi?id=181790&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181790&action=review


> Source/WebKit2/ChangeLog:8
> +	   Add TOUCH_EVENTS guard.

Please add a sentence to say this fixes EFL build without TOUCH_EVENTS.

> Source/WebKit2/Shared/qt/NativeWebTouchEventQt.cpp:29
> +#if ENABLE(TOUCH_EVENTS)
>  #include "NativeWebTouchEvent.h"
> +#endif

This is not correct for Qt.

For performance reason, Qt exclude such files through the project file. In this
case, NativeWebTouchEventQt.cpp is excluded from Target.pri if TOUCH_EVENTS is
not defined.