[webkit-reviews] review granted: [Bug 106385] CanvasRenderingContext2D::setFont argument may reference destroyed object : [Attachment 181773] Patch

[bugzilla-daemon at webkit.org]

Abhishek Arya <inferno at chromium.org> has granted Justin Novosad
<junov at google.com>'s request for review:
Bug 106385: CanvasRenderingContext2D::setFont argument may reference destroyed
object
https://bugs.webkit.org/show_bug.cgi?id=106385

Attachment 181773: Patch
https://bugs.webkit.org/attachment.cgi?id=181773&action=review

------- Additional Comments from Abhishek Arya <inferno at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181773&action=review


> Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:2091
> +    String newFontSafeCopy(newFont); // In case newFont is a ref to a string
touched by realizeSaves

The comment could be improved like "Create a string copy since newFont can be
deleted inside realizeSaves."