[webkit-reviews] review granted: [Bug 106275] Add stub for CanvasProxy : [Attachment 181740] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Gregg Tavares <gman at google.com>'s
request for review:
Bug 106275: Add stub for CanvasProxy
https://bugs.webkit.org/show_bug.cgi?id=106275

Attachment 181740: Patch
https://bugs.webkit.org/attachment.cgi?id=181740&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=181740&action=review


> Source/WebCore/ChangeLog:18
> +	   (WebCore):

I think the convention is to remove these lines now. I wish prepare-ChangeLog
didn't add them.

> Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:38
> +ENABLE_CANVASPROXY = ;

Any reason you chose CANVASPROXY over CANVAS_PROXY which seems to be the style
of all other flags?

> Source/WebCore/html/canvas/CanvasProxy.cpp:2
> + * Copyright (C) 2013 Apple Inc. All rights reserved.

You probably want Google on this :)

> Source/WebCore/html/canvas/CanvasProxy.cpp:13
> + * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY

And here.

> Source/WebCore/html/canvas/CanvasProxy.h:2
> + * Copyright (C) 2013 Apple Inc. All rights reserved.

Ditto.

> Source/WebCore/html/canvas/CanvasProxy.h:35
> +class CanvasProxy;
> +

Don't need this.

> Source/WebCore/html/canvas/CanvasProxy.idl:2
> + * Copyright (C) 2013 Apple Inc. All rights reserved.

Ditto.