[webkit-reviews] review granted: [Bug 106355] [Qt][EFL][WK2] Remove redundant device pixel ratio adjustment from PageViewportController : [Attachment 181717] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Andras Becsi
<abecsi at webkit.org>'s request for review:
Bug 106355: [Qt][EFL][WK2] Remove redundant device pixel ratio adjustment from
PageViewportController
https://bugs.webkit.org/show_bug.cgi?id=106355

Attachment 181717: Patch
https://bugs.webkit.org/attachment.cgi?id=181717&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181717&action=review


> Source/WebKit2/ChangeLog:13
> +	   As a result we can follow the same aproach as QtQuick and all the

spelling

> Source/WebKit2/ChangeLog:15
> +	   coordinates in PageViewportController need to be in device
independent
> +	   pixels (dips) thus we do no longer need to adjust with the device
pixel

AKA UI pixels

> Source/WebKit2/UIProcess/efl/PageViewportControllerClientEfl.cpp:66
> +    // The viewport controller expects sizes in device independent
coordinates.

Maybe it is more understandable saying that

// The viewport controller expects sizes in UI units, and not raw device units.


> Source/WebKit2/UIProcess/efl/PageViewportControllerClientEfl.cpp:67
> +    size.scale(1 / m_controller->devicePixelRatio());

devicePixelRatio is called deviceScaleFactor most places now, maybe we should
rename