[webkit-reviews] review granted: [Bug 106356] Dashboard cleanup: Remove globals g_buildersThatFailedToLoad and g_staleBuilders : [Attachment 181716] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Julie Parent
<jparent at google.com>'s request for review:
Bug 106356: Dashboard cleanup: Remove globals g_buildersThatFailedToLoad and
g_staleBuilders
https://bugs.webkit.org/show_bug.cgi?id=106356

Attachment 181716: Patch
https://bugs.webkit.org/attachment.cgi?id=181716&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181716&action=review


> Tools/TestResultServer/static-dashboards/loader.js:81
> +	       resourceLoadingComplete(this._getLoadingErrorMessages());

I probably would've just inlined _getLoadingErrorMessages() here; it looks like
this is the only caller, right?