[webkit-reviews] review granted: [Bug 101261] test-webkitpy shows failure output on my linux box : [Attachment 181697] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 101261: test-webkitpy shows failure output on my linux box
https://bugs.webkit.org/show_bug.cgi?id=101261

Attachment 181697: Patch
https://bugs.webkit.org/attachment.cgi?id=181697&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181697&action=review


Seems fine.  Makes me think that this Port object may be doing too much. :)

> Tools/Scripts/webkitpy/layout_tests/port/efl_unittest.py:43
> +	   port._unload_pulseaudio_module = lambda: None
> +	   port._restore_pulseaudio_module = lambda: None

I guess there is no PulseAudio object on these ports that you can just mock? 
The port itself handles teh loading/unloading (and presumably actions with)
this code?