[webkit-reviews] review denied: [Bug 105902] Prevent ScrollView::updateScrollbars() from creating scrollbars with negative sizes : [Attachment 181001] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Steve Block
<steveblock at chromium.org>'s request for review:
Bug 105902: Prevent ScrollView::updateScrollbars() from creating scrollbars
with negative sizes
https://bugs.webkit.org/show_bug.cgi?id=105902

Attachment 181001: Patch
https://bugs.webkit.org/attachment.cgi?id=181001&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
I think you misunderstood the feedback.  The right thing to do here is to
figure out how we're entering ScrollView::updateScrollbars() in a situation
where these values are negative, figure out why those situations are arising,
fix the root causes and add tests.

I also highly highly doubt that ScrollView::updateScrollbars is the only source
of negative sizes in GraphicsLayer, so removing the check there will just
reintroduce the crash you're claiming to fix.