[webkit-reviews] review denied: [Bug 82169] [Shadow DOM] Implement a '::distributed()' pseudo element. : [Attachment 181659] Add a test for ::distributed() used in scoped style.

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has denied Hayato Ito <hayato at chromium.org>'s
request for review:
Bug 82169: [Shadow DOM] Implement a '::distributed()' pseudo element.
https://bugs.webkit.org/show_bug.cgi?id=82169

Attachment 181659: Add a test for ::distributed() used in scoped style.
https://bugs.webkit.org/attachment.cgi?id=181659&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=181659&action=review


> Source/WebCore/css/RuleSet.cpp:291
>	   if (rule->isStyleRule())
> -	       addStyleRule(static_cast<StyleRule*>(rule), addRuleFlags);
> +	       resolver->addStyleRule(static_cast<StyleRule*>(rule),
const_cast<ContainerNode*>(scope), this, addRuleFlags);

RuleSet calls to StyleResolver::addStyleRule which then calls back to
RuleSet::addStyleRule. This is bit of spaghetti. Please factor differently (for
example by adding accessors for getting m_shadowDistributedRuleSetMap here).

> Source/WebCore/css/SelectorChecker.cpp:394
> +
> +    case CSSSelector::ShadowDistributed:

Please use SHADOW_DOM guards consistently.