[webkit-reviews] review granted: [Bug 73482] sheriffbot roll-chromium-deps shouldn't create a bug with None as the new revision. : [Attachment 181642] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 7 22:27:04 PST 2013


Ryosuke Niwa <rniwa at webkit.org> has granted Alan Cutter
<alancutter at chromium.org>'s request for review:
Bug 73482: sheriffbot roll-chromium-deps shouldn't create a bug with None as
the new revision.
https://bugs.webkit.org/show_bug.cgi?id=73482

Attachment 181642: Patch
https://bugs.webkit.org/attachment.cgi?id=181642&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181642&action=review


> Tools/Scripts/webkitpy/tool/steps/updatechromiumdeps.py:79
> +	   if new_chromium_revision == None:

It’s probably sufficient to check "not new_chromium_revision" since revision 0
doesn’t exist nor is useful.


More information about the webkit-reviews mailing list