[webkit-reviews] review denied: [Bug 105760] [TexMap] Rename effective[Transform|Opacity|Filters] in TextureMapperLayer. : [Attachment 181137] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 7 20:07:57 PST 2013
Noam Rosenthal <noam at webkit.org> has denied Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 105760: [TexMap] Rename effective[Transform|Opacity|Filters] in
TextureMapperLayer.
https://bugs.webkit.org/show_bug.cgi?id=105760
Attachment 181137: Patch
https://bugs.webkit.org/attachment.cgi?id=181137&action=review
------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181137&action=review
Let's change from m_effectiveXXX to m_currentXXX.
Effective is the multiplied value; current simply means that it's
post-animation and not pre-animation.
> Source/WebKit/qt/ChangeLog:10
> + It can reduce the number of public API of TextureMapperLayer.
This removes unnecessary public API for TextureMapperLayer.
More information about the webkit-reviews
mailing list