[webkit-reviews] review denied: [Bug 106275] Add stub for CanvasProxy : [Attachment 181595] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 7 16:53:14 PST 2013


Adam Barth <abarth at webkit.org> has denied Gregg Tavares <gman at google.com>'s
request for review:
Bug 106275: Add stub for CanvasProxy
https://bugs.webkit.org/show_bug.cgi?id=106275

Attachment 181595: Patch
https://bugs.webkit.org/attachment.cgi?id=181595&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181595&action=review


> Source/WebCore/GNUmakefile.list.am:83
> +	DerivedSources/WebCore/JSCanvasProxy.cpp \
> +	DerivedSources/WebCore/JSCanvasProxy.h \

It looks like you might have forgotten to "svn add" these files.  I'm surprised
that you need custom bindings though.  Can the code generator not handle these
cases?


More information about the webkit-reviews mailing list