[webkit-reviews] review denied: [Bug 73482] sheriffbot roll-chromium-deps shouldn't create a bug with None as the new revision. : [Attachment 181559] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Alan Cutter
<alancutter at chromium.org>'s request for review:
Bug 73482: sheriffbot roll-chromium-deps shouldn't create a bug with None as
the new revision.
https://bugs.webkit.org/show_bug.cgi?id=73482

Attachment 181559: Patch
https://bugs.webkit.org/attachment.cgi?id=181559&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181559&action=review


>> Tools/Scripts/webkitpy/tool/steps/updatechromiumdeps.py:76
>>	    new_chromium_revision = state["chromium_revision"]
> 
> Why don’t we just convert it to int here inside try & except instead of
checking the validity here and then converting it into int in
_validate_revisions?

Yeah, other places we use the ValueException (or something like that) to handle
these cases.