[webkit-reviews] review granted: [Bug 106272] Don't use double tap zoom if minimum and maximum page scale is the same : [Attachment 181588] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 7 16:06:04 PST 2013


James Robinson <jamesr at chromium.org> has granted yusufo at chromium.org's request
for review:
Bug 106272: Don't use double tap zoom if minimum and maximum page scale is the
same
https://bugs.webkit.org/show_bug.cgi?id=106272

Attachment 181588: Patch
https://bugs.webkit.org/attachment.cgi?id=181588&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181588&action=review


> Source/WebKit/chromium/ChangeLog:10
> +We should only try to computed relevant scale and scrollOffset and start the
animation
> +if the page is zoomable. This now creates an undesired animation for mobile
pages which
> +are not zoomable.

nit: this should be 8-space indented


More information about the webkit-reviews mailing list