[webkit-reviews] review granted: [Bug 106268] HTMLTreeBuilder shouldn't keep a Document pointer : [Attachment 181579] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 7 15:51:15 PST 2013


Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 106268: HTMLTreeBuilder shouldn't keep a Document pointer
https://bugs.webkit.org/show_bug.cgi?id=106268

Attachment 181579: Patch
https://bugs.webkit.org/attachment.cgi?id=181579&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181579&action=review


> Source/WebCore/html/parser/HTMLTreeBuilder.cpp:326
> +    m_isAttached = false;

This appears to be a debug-only flag?

> Source/WebCore/html/parser/HTMLTreeBuilder.cpp:826
> -	   if (!m_document->inQuirksMode() &&
m_tree.openElements()->inButtonScope(pTag))
> +	   if (!m_tree.inQuirksMode() &&
m_tree.openElements()->inButtonScope(pTag))

I really like this change.


More information about the webkit-reviews mailing list