[webkit-reviews] review granted: [Bug 106251] Introduce HTMLParserOptions to encapsulate HTML parser options : [Attachment 181558] Patch (no xcodeproj changes yet)

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 106251: Introduce HTMLParserOptions to encapsulate HTML parser options
https://bugs.webkit.org/show_bug.cgi?id=106251

Attachment 181558: Patch (no xcodeproj changes yet)
https://bugs.webkit.org/attachment.cgi?id=181558&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181558&action=review


This is a fantastic change.  This breaks these options from being "dynamic" if
they're supposed to be by being "Settings".  r=me if you make Mac build.

> Source/WebCore/html/parser/HTMLParserOptions.h:36
> +class HTMLParserOptions {
> +public:
> +    bool usePreHTML5ParserQuirks;
> +    unsigned maximumDOMTreeDepth;

I find structs rarely stay that way for long... but OK.