[webkit-reviews] review granted: [Bug 106021] WIP [Chromium] Add support for emulating legacy Android WebView 'UseWideViewport' setting : [Attachment 181500] Factored out dpiIndependentSize

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 106021: WIP [Chromium] Add support for emulating legacy Android WebView
'UseWideViewport' setting
https://bugs.webkit.org/show_bug.cgi?id=106021

Attachment 181500: Factored out dpiIndependentSize
https://bugs.webkit.org/attachment.cgi?id=181500&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181500&action=review


Seems fine apart from naming nits.

> Source/WebKit/chromium/src/WebViewImpl.cpp:-1592
> -	   const int standardFallbackWidth = 980;
> -	   int dpiIndependentViewportWidth = newSize.width /
page()->deviceScaleFactor();
> -	   settings()->setLayoutFallbackWidth(std::max(standardFallbackWidth,
dpiIndependentViewportWidth));

What happened to this code?