[webkit-reviews] review granted: [Bug 106172] Extract a class to represent a test result to simplify PerfTest.parse_output and PageLoadPerfTest._run_with_driver : [Attachment 181432] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 106172: Extract a class to represent a test result to simplify
PerfTest.parse_output and PageLoadPerfTest._run_with_driver
https://bugs.webkit.org/show_bug.cgi?id=106172

Attachment 181432: Patch
https://bugs.webkit.org/attachment.cgi?id=181432&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181432&action=review


> Tools/Scripts/webkitpy/performance_tests/perftest.py:56
> +    allowed_metrics = ('Time', 'Malloc', 'JSHeap')

Nit: I think we normally use ALL_CAPS for constants. Also, this looks like it
is only used in the class so you could _ prefix it.

> Tools/Scripts/webkitpy/performance_tests/perftest.py:59
> +    def __init__(self, metric, unit=None, iterations=None):
> +	   self._metric = metric

Nit: Maybe assert here that metric is in allowed_metrics?

> Tools/Scripts/webkitpy/performance_tests/perftest.py:245
> +		   current_metric = metric_match.group('metric').replace(' ',
'')

It's a bit unfortunate that we use "JS Heap" in one place and "JSHeap" in
another.  Maybe we can clean this up in a follow up.