[webkit-reviews] review requested: [Bug 106147] ResourceHandle::willLoadFromCache is evil : [Attachment 181514] proposed patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 106147: ResourceHandle::willLoadFromCache is evil
https://bugs.webkit.org/show_bug.cgi?id=106147

Attachment 181514: proposed patch
https://bugs.webkit.org/attachment.cgi?id=181514&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Indeed.

I've been running tests locally with one more fix that I removed as unrelated
prior to submitting the patch. Turns out it's not unrelated!

The additional fix is for non-form case
FrameLoader::loadDifferentDocumentItem() - we've been explicitly special casing
https subresources to not use stale data on b/f navigation. The reason this
worked before was that addExtraFieldsToRequest() was resetting cache policy for
b/f navigations after policy delegate.