[webkit-reviews] review canceled: [Bug 106021] WIP [Chromium] Add support for emulating legacy Android WebView 'UseWideViewport' setting : [Attachment 181307] Patch

[bugzilla-daemon at webkit.org]

Mikhail Naganov <mnaganov at chromium.org> has canceled Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 106021: WIP [Chromium] Add support for emulating legacy Android WebView
'UseWideViewport' setting
https://bugs.webkit.org/show_bug.cgi?id=106021

Attachment 181307: Patch
https://bugs.webkit.org/attachment.cgi?id=181307&action=review

------- Additional Comments from Mikhail Naganov <mnaganov at chromium.org>
> For this, please add a new method:
>
> FloatSize WebViewImpl::dpiIndependentSize() const;
>
> And this method should return just m_size if the setting
applyDeviceScaleInCompositor is true.

Done. But I can't add it to the WebView.h interface since FloatSize is a
WebCore type. There is no corresponding type in the public API. The closest
ones are WebFloatPoint and WebFloatRect. Do you think it's OK to leave this
method to be impl-only? Or perhaps we should clamp up floats and return
WebSize?