[webkit-reviews] review denied: [Bug 4363] document.lastModified returns date in UTC time, but should return it in local time : [Attachment 178614] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 6 17:25:58 PST 2013


Hajime Morrita (vacation - Jan 1) <morrita at google.com> has denied Pablo Flouret
<pablof at motorola.com>'s request for review:
Bug 4363: document.lastModified returns date in UTC time, but should return it
in local time
https://bugs.webkit.org/show_bug.cgi?id=4363

Attachment 178614: Patch
https://bugs.webkit.org/attachment.cgi?id=178614&action=review

------- Additional Comments from Hajime Morrita (vacation - Jan 1)
<morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=178614&action=review


> Source/WebCore/dom/Document.cpp:3845
>  {

The approach looks good.

I'd like to take this fix as an opportunity to extract a function which returns
DateComponents.
foundDate flag seems wrong idea.


More information about the webkit-reviews mailing list