[webkit-reviews] review denied: [Bug 101328] MIPS DFG implementation. : [Attachment 181319] DFG for MIPS.

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has denied Balazs Kilvady
<kilvadyb at homejinni.com>'s request for review:
Bug 101328: MIPS DFG implementation.
https://bugs.webkit.org/show_bug.cgi?id=101328

Attachment 181319: DFG for MIPS.
https://bugs.webkit.org/attachment.cgi?id=181319&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=181319&action=review


> Source/JavaScriptCore/dfg/DFGCCallHelpers.h:963
> +#if CPU(MIPS)
> +    ALWAYS_INLINE void setupArgumentsWithExecState(GPRReg arg1, GPRReg arg2,
GPRReg arg3, GPRReg arg4)
> +    {
> +	   poke(arg4, 4);
> +	   setupArgumentsWithExecState(arg1, arg2, arg3);
> +    }
> +

Why is all of this behind CPU(MIPS)?  It looks identical to the normal
NUMBER_OF_ARGUMENT_REGISTERS == 4 case. :-/