[webkit-reviews] review granted: [Bug 106141] [BlackBerry] SelectionHandler::selectAtPoint should use last fat finger result when it is a link : [Attachment 181419] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 5 12:22:55 PST 2013


Rob Buis <rwlbuis at gmail.com> has granted Andy Chen <andchen at rim.com>'s request
for review:
Bug 106141: [BlackBerry] SelectionHandler::selectAtPoint should use last fat
finger result when it is a link
https://bugs.webkit.org/show_bug.cgi?id=106141

Attachment 181419: Patch
https://bugs.webkit.org/attachment.cgi?id=181419&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=181419&action=review


LGTM.

> Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp:587
> +bool SelectionHandler::selectNodeIfFatFingersResultIsLink(FatFingersResult
fatFingersResult)

A long name, but I can't suggest anything better/shorter.


More information about the webkit-reviews mailing list