[webkit-reviews] review denied: [Bug 105480] Implement element type selectors for the WebVTT ::cue pseudo class : [Attachment 181422] Proposed fix 0.2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 5 01:46:27 PST 2013


Antti Koivisto <koivisto at iki.fi> has denied Dima Gorbik <dgorbik at apple.com>'s
request for review:
Bug 105480: Implement element type selectors for the WebVTT ::cue pseudo class
https://bugs.webkit.org/show_bug.cgi?id=105480

Attachment 181422: Proposed fix 0.2
https://bugs.webkit.org/attachment.cgi?id=181422&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
This is hacky. Also tagMatches() is hot and we don't want to add branches
there. I think you should make the WebVTT shadow nodes really have these tag
names (c, v), and add the UA CSS rules to style them.


More information about the webkit-reviews mailing list