[webkit-reviews] review granted: [Bug 90827] seamless iframes don't take border into account properly and make the iframe too small. : [Attachment 181381] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jan 4 16:26:18 PST 2013
Ojan Vafai <ojan at chromium.org> has granted Mike West <mkwst at chromium.org>'s
request for review:
Bug 90827: seamless iframes don't take border into account properly and make
the iframe too small.
https://bugs.webkit.org/show_bug.cgi?id=90827
Attachment 181381: Patch
https://bugs.webkit.org/attachment.cgi?id=181381&action=review
------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181381&action=review
> LayoutTests/fast/frames/seamless/seamless-border.html:7
> + #hasborder { border: 10px solid black; }
Mind adding padding to this test case since your change adds in both border and
padding? Or you can do it in a separate patch. I'm not sure we have test
coverage that padding on seamless iframes works at all. :)
More information about the webkit-reviews
mailing list