[webkit-reviews] review granted: [Bug 106131] Add a script to delete stale zero-byte build files : [Attachment 181391] Updated per comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 4 15:30:37 PST 2013


Tony Chang <tony at chromium.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 106131: Add a script to delete stale zero-byte build files
https://bugs.webkit.org/show_bug.cgi?id=106131

Attachment 181391: Updated per comments
https://bugs.webkit.org/attachment.cgi?id=181391&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181391&action=review


Seems fine as long as you're not seeing spurious rebuilds after running this.

> Tools/ChangeLog:8
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   * BuildSlaveSupport/build.webkit.org-config/master.cfg:

Nit: I would maybe mention that this is Apple Mac only for now.


More information about the webkit-reviews mailing list