[webkit-reviews] review requested: [Bug 106045] [GTK] [WebKit2] Clicking on a word that is selected in an editable area deletes it : [Attachment 181315] Another patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has asked  for review:
Bug 106045: [GTK] [WebKit2] Clicking on a word that is selected in an editable
area deletes it
https://bugs.webkit.org/show_bug.cgi?id=106045

Attachment 181315: Another patch
https://bugs.webkit.org/attachment.cgi?id=181315&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
I think both patches can be complementary. this patch ensures we do the same
than we currently in wk1. 

GtkInputMethodFilter::notifyMouseButtonPress() calls
confirmCurrentComposition() which ends up calling Editor::confirmComposition(),
the version without receiving a String. In WebKit2, we are using a single
message ConfirmComposition. When confirmCurrentComposition is called in WebKit2
ConfirmComposition message is sent with a NULL String, and the web process ends
up calling Editor::confirmComposition(String). We need to handle the special
case of the NULL string to call Editor::confirmComposition() without the
string.