[webkit-reviews] review requested: [Bug 106021] WIP [Chromium] Add support for emulating legacy Android WebView 'UseWideViewport' setting : [Attachment 181307] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 4 09:02:30 PST 2013


Mikhail Naganov <mnaganov at chromium.org> has asked  for review:
Bug 106021: WIP [Chromium] Add support for emulating legacy Android WebView
'UseWideViewport' setting
https://bugs.webkit.org/show_bug.cgi?id=106021

Attachment 181307: Patch
https://bugs.webkit.org/attachment.cgi?id=181307&action=review

------- Additional Comments from Mikhail Naganov <mnaganov at chromium.org>
Thanks for the suggestion, Alexandre! I've updated the patch.

As for the fallback setting code I'm removing -- the default value for
'LayoutFallbackWidth' is set in Source/WebCore/page/Settings.in to 980. The
code I'm removing actually violates the usage pattern of WebCore settings, as
they should be updated by the embedder. For example, in the case when the
embedder sets LayoutFallbackWidth to a non-default value, the aforementioned
code will just reset it with its own value, which seems to be unacceptable.


More information about the webkit-reviews mailing list