[webkit-reviews] review denied: [Bug 106052] [WK2] [Gtk] crash when web inspector is attached, and window height is reduced. : [Attachment 181242] patch proposal: updated patch: wrong static_cast
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jan 4 06:34:26 PST 2013
Carlos Garcia Campos <cgarcia at igalia.com> has denied arno.
<arno at renevier.net>'s request for review:
Bug 106052: [WK2] [Gtk] crash when web inspector is attached, and window height
is reduced.
https://bugs.webkit.org/show_bug.cgi?id=106052
Attachment 181242: patch proposal: updated patch: wrong static_cast
https://bugs.webkit.org/attachment.cgi?id=181242&action=review
------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
I don't think detaching the inspector is the right fix, here. There are
actually two bugs, we shouldn't allocate for the children a size bigger than
the parent, and we should make sure the widget allocation is always >= 1 (which
is what GTK does in gtk_widget_size_allocate())
More information about the webkit-reviews
mailing list