[webkit-reviews] review granted: [Bug 106082] [GTK][Qt] Make compositing messages async again : [Attachment 181287] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jan 4 04:33:11 PST 2013
Simon Hausmann <hausmann at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 106082: [GTK][Qt] Make compositing messages async again
https://bugs.webkit.org/show_bug.cgi?id=106082
Attachment 181287: Patch
https://bugs.webkit.org/attachment.cgi?id=181287&action=review
------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
The composition messages from the UI process to the Web process must be async
for sure. Synchronous messages from WebProcess to the UI process are okay(ish),
but the other way around is a wonderful source of crashes because they still
allow for the processing of other sync messages, so they aren't fully blocking.
In Qt we made it a policy to not have these, so if we want to share the code
this change fixes a regression. If Gtk needs the messages to remain sync, then
we have to fork the code.
More information about the webkit-reviews
mailing list