[webkit-reviews] review granted: [Bug 105685] Cleanup perftest* tests and add a test for computing statistics : [Attachment 180617] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 3 18:35:22 PST 2013
Eric Seidel <eric at webkit.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 105685: Cleanup perftest* tests and add a test for computing statistics
https://bugs.webkit.org/show_bug.cgi?id=105685
Attachment 180617: Patch
https://bugs.webkit.org/attachment.cgi?id=180617&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=180617&action=review
OK.
> Tools/Scripts/webkitpy/performance_tests/perftest.py:215
> + @staticmethod
> + def compute_statistics(values):
static methods are rarely worth it in python. :( They're just hard to mock.
More information about the webkit-reviews
mailing list