[webkit-reviews] review granted: [Bug 105445] WebKitCSSTransformValue::customCssText() should always allocate once : [Attachment 180202] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 3 15:52:03 PST 2013
Alexis Menard (darktears) <alexis at webkit.org> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 105445: WebKitCSSTransformValue::customCssText() should always allocate
once
https://bugs.webkit.org/show_bug.cgi?id=105445
Attachment 180202: Patch
https://bugs.webkit.org/attachment.cgi?id=180202&action=review
------- Additional Comments from Alexis Menard (darktears) <alexis at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=180202&action=review
Ok with comments.
> Source/WebCore/ChangeLog:9
> + it was typically done with 2 memory allocation due to the string
size in StringBuilder.
Typo. allocation -> allocations.
> Source/WebCore/ChangeLog:11
> + This patch change to code to use the String Concatenate opeartions
in order
Typo. Fix when landing.
More information about the webkit-reviews
mailing list