[webkit-reviews] review granted: [Bug 47975] letter-spacing set's weird width when clearing floats : [Attachment 180605] Patch

Thu Jan 3 13:36:01 PST 2013

Levi Weintraub <leviw at chromium.org> has granted Robert Hogan
<robert at webkit.org>'s request for review:
Bug 47975: letter-spacing set's weird width when clearing floats
https://bugs.webkit.org/show_bug.cgi?id=47975

Attachment 180605: Patch
https://bugs.webkit.org/attachment.cgi?id=180605&action=review

------- Additional Comments from Levi Weintraub <leviw at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=180605&action=review

Patch doesn't apply to ToT :(

r=me after the nits are addressed.

> Source/WebCore/ChangeLog:3
> +	   letter-spacing set's weird width when clearing floats

Update the title to describe the actual bug, since letter-spacing isn't the
issue here.

>
LayoutTests/fast/block/float/max-width-clear-float-with-overflow-hidden.html:1
> +<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01//EN"
"http://www.w3.org/TR/html4/strict.dtd">

Why the long doctype instead of just !DOCTYPE html?