[webkit-reviews] review granted: [Bug 105958] [Mac] [WK2] platform/mac/fast/events/numpad-keycode-mapping.html fails : [Attachment 181209] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 3 13:27:25 PST 2013

Alexey Proskuryakov <ap at webkit.org> has granted Sailesh Agrawal
<sail at chromium.org>'s request for review:
Bug 105958: [Mac] [WK2] platform/mac/fast/events/numpad-keycode-mapping.html

Attachment 181209: Patch

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181209&action=review

> Tools/WebKitTestRunner/mac/EventSenderProxy.mm:370
> +	       eventCharacter = currentCharacterString;

I'm not sure why this assignment is needed. We were not assigning to
eventCharacter in the code that you remove.

More information about the webkit-reviews mailing list