[webkit-reviews] review granted: [Bug 105961] Fix overflow in LayoutUnit::ceil and floor for SATURATED_LAYOUT_ARITHMETIC : [Attachment 181112] Patch

[bugzilla-daemon at webkit.org]

Levi Weintraub <leviw at chromium.org> has granted Emil A Eklund
<eae at chromium.org>'s request for review:
Bug 105961: Fix overflow in LayoutUnit::ceil and floor for
SATURATED_LAYOUT_ARITHMETIC
https://bugs.webkit.org/show_bug.cgi?id=105961

Attachment 181112: Patch
https://bugs.webkit.org/attachment.cgi?id=181112&action=review

------- Additional Comments from Levi Weintraub <leviw at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181112&action=review


This seems fine to me. I'd be curious to see the perf results (which I suspect
are negligible), but since this flag isn't enabled, I think it's enough to
watch the overall impact of enabling it.

> Source/WebCore/ChangeLog:3
> +	   Fix overflow in LayoutUnit::ceil and flor for
SATURATED_LAYOUT_ARITHMETIC

Typo: 'flor'

> Source/WebCore/platform/LayoutUnit.h:230
> +	   if (UNLIKELY(m_value <= INT_MIN + kEffectiveFixedPointDenominator -
1))
> +	       return intMinForLayoutUnit;

I'm not used to seeing UNLIKELY in WebCore code, but I imagine if I'm going to
run into it, I'd expect it in platform/.

> Tools/ChangeLog:3
> +	   Fix overflow in LayoutUnit::ceil and flor for
SATURATED_LAYOUT_ARITHMETIC

'flor'