[webkit-reviews] review denied: [Bug 84778] webkit fails IETC column-width-negative-001.htm : [Attachment 181199] Updated Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Uday Kiran <udaykiran at motorola.com>'s
request for review:
Bug 84778: webkit fails IETC column-width-negative-001.htm
https://bugs.webkit.org/show_bug.cgi?id=84778

Attachment 181199: Updated Patch
https://bugs.webkit.org/attachment.cgi?id=181199&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181199&action=review


The change looks fine, but the test could be better.  I see some red at the
edges of the letters due to text antialiasing which is confusing.

I would convert this from a ref test to a dumpAsText test (they run faster and
are easier to know if it passes or fails) and use
fast/js/resources/js-test-pre.js.  The change has to do with CSS parsing, so
you could simply have a div with column-width: 0 and read the value back out
using getComputedStyle (it should be auto).

> LayoutTests/fast/multicol/column-width-zero.html:15
> +		   -moz-column-width: 0em;

0 shouldn't have a unit.