[webkit-reviews] review granted: [Bug 105832] [style] WebIDL-reflecting upper-case enums reported as style violation : [Attachment 181157] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 105832: [style] WebIDL-reflecting upper-case enums reported as style
violation
https://bugs.webkit.org/show_bug.cgi?id=105832

Attachment 181157: Patch
https://bugs.webkit.org/attachment.cgi?id=181157&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181157&action=review


> Tools/Scripts/webkitpy/style/checkers/cpp.py:2097
> +    enum_state.is_webidl_enum = bool(match(r'\s*// Web(?:Kit)?IDL enum\s*$',
clean_lines.raw_lines[line_number])) if not enum_state.is_webidl_enum else True


Nit: I would probably do:
enum_state.is_webidl_enum |= bool(match(r'\s*// Web(?:Kit)?IDL enum\s*$',
clean_lines.raw_lines[line_number]))