[webkit-reviews] review denied: [Bug 105786] [TexMap] Use a premuliplied color in TextureMapperGL. : [Attachment 181131] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 3 09:31:41 PST 2013
Noam Rosenthal <noam at webkit.org> has denied Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 105786: [TexMap] Use a premuliplied color in TextureMapperGL.
https://bugs.webkit.org/show_bug.cgi?id=105786
Attachment 181131: Patch
https://bugs.webkit.org/attachment.cgi?id=181131&action=review
------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181131&action=review
> Source/WebCore/ChangeLog:12
> + Covered by existing pixel/ref tests when run on Qt/EFL/GTK.
I think it needs a new ref test for directly composited solid color with
opacity.
> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:125
> + options.textureMapper->drawSolidColor(m_state.contentsRect,
transform, m_state.solidColor);
This still needs to multiply the solid color's alpha with the opacity value
More information about the webkit-reviews
mailing list