[webkit-reviews] review denied: [Bug 105839] [HTMLTemplateElement] Allow <template> content to be inspected : [Attachment 181141] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 3 00:44:31 PST 2013


Pavel Feldman <pfeldman at chromium.org> has denied Rafael Weinstein
<rafaelw at chromium.org>'s request for review:
Bug 105839: [HTMLTemplateElement] Allow <template> content to be inspected
https://bugs.webkit.org/show_bug.cgi?id=105839

Attachment 181141: Patch
https://bugs.webkit.org/attachment.cgi?id=181141&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181141&action=review


> Source/WebCore/dom/Document.cpp:616
> +	   m_inertDocument.clear();

This will happen on its own.

> Source/WebCore/dom/Document.cpp:5949
> +Document* Document::inertDocument()

I don't find the new name self-explanatory, I'd rather leave it as is. r- is
for this, otherwise lgtm.


More information about the webkit-reviews mailing list