[webkit-reviews] review denied: [Bug 105982] Adding favicon.ico to the garden-o-matic. : [Attachment 181145] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Tim 'mithro' Ansell
<mithro at mithis.com>'s request for review:
Bug 105982: Adding favicon.ico to the garden-o-matic.
https://bugs.webkit.org/show_bug.cgi?id=105982

Attachment 181145: Patch
https://bugs.webkit.org/attachment.cgi?id=181145&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181145&action=review


> Tools/Scripts/webkitpy/tool/servers/gardeningserver.py:34
> +import base64
>  import logging
>  import json
>  import os
>  import sys
> +import tempfile
>  import urllib
> +import zlib

These imports are no longer needed.

> Tools/Scripts/webkitpy/tool/servers/gardeningserver.py:123
> +	   self._serve_file('garden-o-matic.ico')

Why not call it favicon.ico or have the web app use the name
garden-o-matic.ico.  It seems odd to change the name here.

In fact, you don't need code at all.  You can just add "ico" to
STATIC_FILE_EXTENSIONS